Horton

Re: Modify the DECLARE CURSOR command tag depending on the scrollable flag

Boszormenyi Zoltan <zb@cybertec.at>

View thread
From: Boszormenyi Zoltan <zb@cybertec.at>
To: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter_e@gmx.net>, Alvaro Herrera <alvherre@2ndquadrant.com>, Michael Meskes <meskes@postgresql.org>, Noah Misch <noah@leadboat.com>, Robert Haas <robertmhaas@gmail.com>, PG Hackers <pgsql-hackers@postgresql.org>, Heikki Linnakangas <hlinnakangas@vmware.com>, Bruce Momjian <bruce@momjian.us>, Hans-Jürgen Schönig <hs@cybertec.at>
Date: 2013-11-28T09:23:06Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix some "translator:" comments mangled by pgindent

  2. Make sure float4in/float8in accept all standard spellings of "infinity".

2013-11-28 09:55 keltezéssel, Michael Meskes írta:
> On Thu, Nov 28, 2013 at 09:04:17AM +0100, Boszormenyi Zoltan wrote:
>>>> Well, technically, unspecified means NO SCROLL according to the SQL
>>>> standard.  A lot of applications in ECPG are ported from other systems,
> That means by automatically adding a literal NO SCROLL to the command we obey
> standard, right? That's fine by me.
>
>>> behavior applies, but it might break existing apps that were unknowingly
>>> relying on a simple cursor being scrollable.  OTOH any such app would be
>>> subject to breakage anyway as a result of planner changes, so it's hard to
>>> complain against this, as long as it's happening in a major version
>>> update.
> Ported applications might be in the same boat. I'm not sure if all other DBMSs
> stick with the standard if nothing is specified. So again, adding it might help
> make it clearer.
>
>> Anyway, is explicitly adding NO SCROLL the preferred solution for everyone?
> +1 from me.

Thanks, I will rework the patches this way.

>
> Michael


-- 
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
      http://www.postgresql.at/