Horton

Re: ResourceOwner refactoring

Heikki Linnakangas <hlinnaka@iki.fi>

View thread View on postgr.es
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Aleksander Alekseev <aleksander@timescale.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Cc: Andres Freund <andres@anarazel.de>, Julien Rouhaud <rjuju123@gmail.com>, Robert Haas <robertmhaas@gmail.com>
Date: 2023-05-25T17:14:23Z
Lists: pgsql-hackers

Attachments

On 23/05/2023 16:41, Aleksander Alekseev wrote:
> Hi,
> 
>> [...]
>> A-ha, it's because I didn't add the new test_resowner directory to the
>> src/test/modules/meson.build file. Fixed.
>>
>> Thanks for the review!
> 
> You probably already noticed, but for the record: cfbot seems to be
> extremely unhappy with the patch.

Thanks, here's a fixed version. (ResourceOwner resource release 
callbacks mustn't call ResourceOwnerForget anymore, but AbortBufferIO 
was still doing that)

-- 
Heikki Linnakangas
Neon (https://neon.tech)

Commits

  1. Make RelationFlushRelation() work without ResourceOwner during abort

  2. Fix bug in bulk extending temp relation after failure

  3. Add missing PGDLLIMPORT markings

  4. Add test_dsa module.

  5. Clear CurrentResourceOwner earlier in CommitTransaction.

  6. Fix dsa.c with different resource owners.

  7. Fix bug in the new ResourceOwner implementation.

  8. Change pgcrypto to use the new ResourceOwner mechanism.

  9. Use a faster hash function in resource owners.

  10. Make ResourceOwners more easily extensible.

  11. Move a few ResourceOwnerEnlarge() calls for safety and clarity.