Re: split func.sgml to separated individual sgml files
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>,
Florents Tselai <florents.tselai@gmail.com>,
Euler Taveira <euler@eulerto.com>,
jian he <jian.universality@gmail.com>,
"David G. Johnston" <david.g.johnston@gmail.com>,
Corey Huinker <corey.huinker@gmail.com>,
pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-09-30T20:15:32Z
Lists: pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes: > On 2025-09-12 Fr 10:12 AM, Nazir Bilal Yavuz wrote: >> Test's name is 'sgml_syntax_check' in the Meson. One difference I >> noticed: I could not find a way in Meson to create a test that does >> not run by default. As a result, this syntax test runs every time you >> run the 'meson test'. This behaviour differs from Autoconf, but I >> think it is acceptable. Actually, I've been meaning to complain about the fact that these checks aren't run by the default Makefile target. I never remember that there is a separate "check" target, and even if I did remember it's mostly useless to me because I always want to look at the rendered HTML. So when I'm working on the docs I always just say "make" in the doc/src/sgml directory. It'd be helpful, at least to me, if the default target ran the tabs and nbsp checks. It already does run xmllint, so that change could probably be integrated with what you've done here without too much trouble. > This got preempted slightly by Tom's commit 170a8a3f460, but I think > it's worth doing. I tried to simplify it some. See attached. There > doesn't seem to me to be any point in using a different set of files for > the tab tests and the NBSP tests. If we use the same set of files we can > improve the efficiency easily by opening them only once. Here we just > look for all the sgml files and all the xsl files and process them all. +1 for merging those two checks into one pass, especially if we're to run them by default. regards, tom lane
Commits
-
Revert "Improve docs syntax checking"
- 5b5e8a29c13a 19 (unreleased) landed
-
Improve docs syntax checking
- b29225627262 19 (unreleased) landed
-
Teach doc/src/sgml/Makefile about the new func/*.sgml files.
- 170a8a3f4605 19 (unreleased) cited
-
Split func.sgml into more manageable pieces
- 4e23c9ef65ac 19 (unreleased) landed
-
Doc: add check to detect non-breaking spaces in the docs.
- 5b7da5c261d1 18.0 cited