Re: [PATCH] Avoid mixing custom and OpenSSL BIO functions
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Benjamin <davidben@google.com>
Cc: Daniel Gustafsson <daniel@yesql.se>, Andres Freund <andres@anarazel.de>,
PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>,
Peter Eisentraut <peter@eisentraut.org>
Date: 2024-11-29T18:36:21Z
Lists: pgsql-hackers
David Benjamin <davidben@google.com> writes: > Thanks! I got asked about release branches, so I thought I'd pass it along: > how do you all handle merges to release branches and would it make sense to > merge this change? On the one hand, nothing is actively on fire yet, but > the current setup does risk breakage if OpenSSL ever migrates BIO_s_socket > to their new size_t-clean internals. We theoretically could back-patch 6f782a2a1, as it doesn't appear to introduce any ABI-breaking changes. (The new field in struct Port could be an issue, but it looks like it fits into what was padding space, so probably fine.) However, I'm not sure that it's attractive to do so from a risk/benefit standpoint. That code's received only minimal testing so far, and the problem it's fixing is as yet hypothetical. On balance I think I'd vote against a back-patch now. We could reconsider next year once PG v18 has gotten a reasonable amount of beta testing. regards, tom lane
Commits
-
Avoid mixing custom and OpenSSL BIO functions
- 6f782a2a1738 18.0 landed
-
Use BIO_{get,set}_app_data instead of BIO_{get,set}_data.
- c82207a548db 17.0 cited