Re: Fix compiler warnings on 64-bit Windows
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-02-17T08:44:20Z
Lists: pgsql-hackers
Attachments
- 0001-Require-stdint.h.patch (text/plain) patch 0001
On 2020-02-14 15:52, Tom Lane wrote: > Yeah, I think that the C99 requirement has obsoleted a number of configure > tests and related hackery in c.h. We just haven't got round to cleaning > that up yet. > > BTW: I'm still concerned about the possibility of the C library being > less than C99. The model that was popular back then, and which still > exists on e.g. gaur, was that you could install a C99 *compiler* on > a pre-C99 system, and the compiler would bring its own standard header > files as necessary. While I don't have the machine booted up to check, > I'm pretty sure that gaur's <stdint.h> is being supplied by the gcc > installation not directly from /usr/include. On the other hand, that > compiler installation is still dependent on the vendor-supplied libc. Yeah, stdint.h belongs to the compiler, whereas intttypes.h belongs to the C library. So if we require a C99 compiler we can get rid of all tests and workarounds for stdint.h missing. Patch attached. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Fix compiler warnings on 64-bit Windows
- 3f9c1697dca0 13.0 landed
-
Require stdint.h
- 957338418b69 13.0 landed