Horton

Re: Improve error messages for database object stats manipulation functions during recovery

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers@lists.postgresql.org
Date: 2024-11-15T17:36:54Z
Lists: pgsql-hackers

Attachments


On 2024/11/13 6:09, Heikki Linnakangas wrote:
> On 25/10/2024 20:07, Fujii Masao wrote:
>> Hi,
>>
>> When database object stats manipulation functions like pg_set_relation_stats() are run,
>> they currently produce the following error and hint messages, which are "internal"
>> and make it hard for users to understand the issue:
>>
>>        ERROR:  cannot acquire lock mode ShareUpdateExclusiveLock on database objects while recovery is in progress
>>        HINT:  Only RowExclusiveLock or less can be acquired on database objects during recovery.
>>
>> So I'd like to propose updating these to clearer messages:
>>
>>        ERROR:  recovery is in progress
>>        HINT:  Database object statistics manipulation functions cannot be executed during recovery.
>>
>> Thought?
> 
> Makes sense.
> 
> "Database object statistics manipulation functions" is a bit of a mouthful". Maybe something like "statistics cannot be modified during recovery".

Sounds good! I've updated the hint messages as suggested and attached the revised patch.
Thanks for the review!

Unless there are any objections, I'll proceed with committing it.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. Improve error message for database object stats manipulation functions.