Horton

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])

Josh Berkus <josh@agliodbs.com>

View thread View on postgr.es
From: Josh Berkus <josh@agliodbs.com>
To: Andres Freund <andres@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, Amit kapila <amit.kapila@huawei.com>, Fujii Masao <masao.fujii@gmail.com>, Boszormenyi Zoltan <zb@cybertec.at>, Magnus Hagander <magnus@hagander.net>, Peter Eisentraut <peter_e@gmx.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2013-07-17T22:28:58Z
Lists: pgsql-hackers 
On 07/17/2013 03:17 PM, Andres Freund wrote:
> On 2013-07-17 17:05:40 -0400, Alvaro Herrera wrote:
>> Robert Haas escribió:
>>
>>> This feature doesn't strike me as a good candidate for regression
>>> testing anyway.  Keep in mind that people are intended to be able to
>>> run make installcheck against a deployed system without messing it up.
>>
>> This is my opinion as well.
> 
> Setting and resetting a GUC like pg_regress.test_var or so shouldn't be
> too invasive. Some minimal testing seems like a good idea to me.

Also, we can "make check" even if we don't "make installcheck".

-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com