Horton
Menu

Re: pg_filedump 9.3: checksums (and a few other fixes)

Josh Berkus <josh@agliodbs.com>

View thread
From: Josh Berkus <josh@agliodbs.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Peter Geoghegan <pg@heroku.com>, Jeff Davis <pgsql@j-davis.com>, Satoshi Nagayasu <snaga@uptime.jp>, Josh Kupershmidt <schmiddy@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2013-07-16T21:31:03Z
Lists: pgsql-hackers 
On 07/08/2013 04:59 PM, Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> Well, Tom opined in
>> http://www.postgresql.org/message-id/23249.1370878717@sss.pgh.pa.us that
>> the current patch is okay.  I have a mild opinion that it should instead
>> print only SHR_LOCK when both bits are set, and one of the others when
>> only one of them is set.  But I don't have a strong opinion about this,
>> and since Tom disagrees with me, feel free to exercise your own (Jeff's)
>> judgement.
> 
> FWIW, I think that's exactly what I did in the preliminary 9.3 patch
> that I committed to pg_filedump a few weeks ago.  Could you take a look
> at what's there now and see if that's what you meant?

So, is this getting committed today, or do we bounce it?

-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Refactor checksumming code to make it easier to use externally.