Horton

Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]

Josh Berkus <josh@agliodbs.com>

View thread View on postgr.es
From: Josh Berkus <josh@agliodbs.com>
To: Simon Riggs <simon@2ndQuadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Amit Kapila <amit.kapila@huawei.com>, Andres Freund <andres@2ndquadrant.com>, Craig Ringer <craig@2ndquadrant.com>, Jameison Martin <jameisonb@yahoo.com>, Noah Misch <noah@leadboat.com>, Kevin Grittner <kgrittn@mail.com>, robertmhaas@gmail.com, pgsql-hackers@postgresql.org
Date: 2013-06-24T20:32:41Z
Lists: pgsql-hackers 
Simon,

> I think its rather a shame that the proponents of this patch have
> tried so hard to push this through without working variations on the
> theme. Please guys, go away and get creative; rethink the approach so
> that you can have your lunch without anybody else losing theirs. I
> would add that I have seen the use case and want to support it, but
> we're looking to add to the codebase not just steal small bites of
> performance from existing use cases.

Do we really have ironclad numbers which show that the patch affects
performance negatively?  I didn't think the previous performance test
was comprehensive; I was planning to develop one myself this week.

-- 
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com

Commits

  1. Don't assume that a tuple's header size is unchanged during toasting.