Horton

Re: erroneous restore into pg_catalog schema

Heikki Linnakangas <hlinnakangas@vmware.com>

View thread View on postgr.es
From: Heikki Linnakangas <hlinnakangas@vmware.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: Andres Freund <andres@2ndquadrant.com>, Marko Kreen <markokr@gmail.com>, Dimitri Fontaine <dimitri@2ndQuadrant.fr>, Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Erik Rijkers <er@xs4all.nl>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Kohei KaiGai <kaigai@kaigai.gr.jp>
Date: 2013-06-03T07:52:35Z
Lists: pgsql-hackers 
On 14.05.2013 15:35, Stephen Frost wrote:
> * Andres Freund (andres@2ndquadrant.com) wrote:
>> I don't disagree, but how is that relevant for fixing the issue at hand?
>> We still need to fix restores that currently target the wrong schema in
>> a backward compatible manner?
>
> On this, I agree w/ Tom that we should put that check back into place-
> it's really too late to do anything else.

In the interest of getting the release out, I've reverted commit 
a475c603. We'll probably want to do something more elegant in the 
future, but this will do for now.

- Heikki

Commits

  1. Extend and improve use of EXTRA_REGRESS_OPTS.

  2. Remove misplaced sanity check from heap_create().

  3. Silently ignore any nonexistent schemas that are listed in search_path.