Horton

Re: Improvements in psql hooks for variables

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Daniel Verite" <daniel@manitou-mail.org>
Cc: "Rahila Syed" <rahilasyed90@gmail.com>, "Stephen Frost" <sfrost@snowman.net>, "Ashutosh Bapat" <ashutosh.bapat@enterprisedb.com>, "pgsql-hackers" <pgsql-hackers@postgresql.org>, "Andrew Dunstan" <andrew@dunslane.net>
Date: 2017-02-01T16:26:55Z
Lists: pgsql-hackers 
"Daniel Verite" <daniel@manitou-mail.org> writes:
> That works for me. I tested and read it and did not find anything
> unexpected or worth objecting.
> "\unset var" acting as "\set var off" makes sense considering
> that its opposite "\set var" is now an accepted
> synonym of "\set var on" for the boolean built-ins.

Thanks for reviewing!  I've pushed this now --- Andrew, you should
be able to revert the RedisFDW test script to the way it was.

			regards, tom lane

Commits

  1. Clean up psql's behavior for a few more control variables.

  2. Make psql's \set display variables in alphabetical order.

  3. Improve psql's behavior for \set and \unset of its control variables.

  4. Make psql reject attempts to set special variables to invalid values.