Re: unlogged tables vs. GIST

Heikki Linnakangas <hlinnakangas@vmware.com>

From: Heikki Linnakangas <hlinnakangas@vmware.com>

To: Jeevan Chalke <jeevan.chalke@enterprisedb.com>

Cc: Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2013-02-11T13:58:06Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

The GiST scan algorithm uses LSNs to detect concurrent pages splits, but
- 2edc5cd493ce 9.1.0 cited

Attachments

unlogged-gist-indexes-v4.patch (text/x-diff) patch v4

On 11.02.2013 08:44, Jeevan Chalke wrote:
> Hi,
>
> Any review comments on this ?

Sorry for the delay.

I did some minor cleanup on this. I added code to pg_resetxlog and 
pg_controldata to reset / display the current unlogged LSN value. I 
moved the static counter, for temporary relations, back to gistutil.c, 
so that the function in xlog.c only deals with unlogged relations. It's 
debatable if that's better, but IMHO it is. Also, the unloggedLSN 
counter is now reset to 1 at crash recovery. There's no fundamental 
reason it needs to be reset, rather than just continue from the last 
shutdowned value like nothing happened, but it seems cleaner that way.

I'm happy with this now, but please take one more look before I commit this.

- Heikki