Re: broken regress tests on fedora 36
Peter Eisentraut <peter.eisentraut@enterprisedb.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>,
Pavel Stehule <pavel.stehule@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-06-09T13:41:08Z
Lists: pgsql-hackers
On 07.06.22 14:56, Michael Paquier wrote: > On Tue, Jun 07, 2022 at 10:52:45AM +0200, Pavel Stehule wrote: >> # Failed test '\timing with query error: timing output appears' >> # at t/001_basic.pl line 95. >> # 'Time: 0,293 ms' >> # doesn't match '(?^m:^Time: \d+\.\d\d\d ms)' >> # Looks like you failed 2 tests of 58. > > Fun. The difference is in the separator: dot vs comma. This should > fail with French the same way. Perhaps it would fail differently in > other languages? There is no need to be that precise with the regex > IMO, so I would just cut the regex with the number, checking only the > unit at the end. Shouldn't we reset the locale setting (LC_NUMERIC?) to a known value? We clearly already do that for other categories, or it wouldn't say "Time:".
Commits
-
Fix portability issue in TAP tests of psql for locales
- ca899d98b4aa 15.0 landed