Re: Order changes in PG16 since ICU introduction

Jeff Davis <pgsql@j-davis.com>

View thread

From: Jeff Davis <pgsql@j-davis.com>

To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Daniel Verite <daniel@manitou-mail.org>

Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org

Date: 2023-06-05T17:54:58Z

Lists: pgsql-hackers

Attachments

v8-0001-ICU-support-locale-C-with-the-same-behavior-as-li.patch (text/x-patch) patch v8-0001
v8-0002-pg_upgrade-check-for-ICU-locale-C-in-versions-15-.patch (text/x-patch) patch v8-0002
v8-0003-Make-LOCALE-apply-to-ICU_LOCALE-for-CREATE-DATABA.patch (text/x-patch) patch v8-0003
v8-0004-Use-database-default-collation-s-provider-as-defa.patch (text/x-patch) patch v8-0004

New patch series attached. I plan to commit 0001 and 0002 soon, unless
there are objections.

0001 causes the "C" and "POSIX" locales to be treated with
memcmp/pg_ascii semantics in ICU, just like in libc. We also considered
a new "none" provider, but it's more invasive, and we can always
reconsider that in the v17 cycle.

0002 introduces an upgrade check for users who have explicitly
requested provider=icu and iculocale=C on older versions, and rejects
upgrading from v15 in that case to avoid index corruption. Having such
a collation is almost certainly a mistake by the user, because the
collator would not give the expected memcmp semantics.


-- 
Jeff Davis
PostgreSQL Contributor Team - AWS

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Introduce "builtin" collation provider.
- 2d819a08a1cb 17.0 landed
ICU: do not convert locale 'C' to 'en-US-u-va-posix'.
- f3a01af29b19 16.0 landed
- f7faa9976cc0 16.0 landed
initdb: change default --locale-provider back to libc.
- 2535c74b1a61 16.0 landed
CREATE DATABASE: make LOCALE apply to all collation providers.
- a14e75eb0b6a 16.0 landed
Remove read-only server settings lc_collate and lc_ctype
- b0f6c437160d 16.0 landed
ICU: use uloc_getDefault() for initdb.
- ec1264f01e37 16.0 landed
Doc fixes for commit 1e16af8ab5.
- f4a9422c0c37 16.0 landed
Doc: fix some rendering problems in the PDF docs build.
- b62381d9a23b 16.0 landed
Doc improvements for language tags and custom ICU collations.
- 1e16af8ab5d7 16.0 landed
ICU: check for U_STRING_NOT_TERMINATED_WARNING.
- 1c634f6647c2 16.0 landed
Reduce icu_validation_level default to WARNING.
- 6de31ce446e5 16.0 landed
Revert "ICU: do not convert locale 'C' to 'en-US-u-va-posix'."
- 455f948b0d03 16.0 landed
Fix initdb --no-locale.
- 5cd1a5af4d17 16.0 landed
Avoid character classification in regex escape parsing.
- c04c6c5d6f5f 16.0 cited