Horton

Re: pg_ctl idempotent option

Peter Eisentraut <peter_e@gmx.net>

View thread View on postgr.es
From: Peter Eisentraut <peter_e@gmx.net>
To: Bruce Momjian <bruce@momjian.us>
Cc: Simon Riggs <simon@2ndQuadrant.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Date: 2013-01-29T21:34:50Z
Lists: pgsql-hackers 
On 1/28/13 9:29 PM, Bruce Momjian wrote:
> pg_upgrade uses that to find out of the server was already running or if
> we started it.  This is to start the server to remove the
> postmaster.pid file.

It's currently a bit missed up anyway.  pg_ctl start is successful if
the server is already started, but pg_ctl -w start fails.

What pg_upgrade is doing doesn't sound particularly safe, for example
when something is concurrently starting or stopping the server.

> Also, no one has explained how not knowing if -o
> options were used was a safe.

Hmm, good point.  But we already have this problem -- see above.