Re: Synchronize with imath upstream
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>, pgsql-hackers@postgresql.org
Date: 2019-02-03T15:31:26Z
Lists: pgsql-hackers
Noah Misch <noah@leadboat.com> writes:
> The -Wno-declaration-after-statement approach takes eight lines of code, and
> the filter-out approach takes one. On the other hand, using $(filter-out)
> changes any runs of whitespace to single spaces ("$(filter-out foo,a b c)"
> yields "a b c"). We do risk that with CPPFLAGS and LDFLAGS in a few places.
> I don't want to proliferate that practice, because it changes semantics of
> CFLAGS containing -DFOO="arbitrary text".
I don't particularly buy that argument, because CPPFLAGS is where any -D
switches ought to be put. So we've already exposed ourselves to this
risk, in the unlikely scenario where it's not hypothetical.
regards, tom lane
Commits
-
Import changes from IMath versions (1.3, 1.29].
- 48e24ba6b7fd 12.0 landed
-
Cherry-pick security-relevant fixes from upstream imath library.
- 8b59672d8d23 9.5.0 cited