Re: coverage increase for worker_spi

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-05-30T16:51:27Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2019-May-29, Tom Lane wrote:
>> I'm not opposed to adding a new test case at this point in the cycle,
>> but as written this one seems more or less guaranteed to fail under
>> load.

> True.  Here's a version that should be more resilient.

Hm, I don't understand how this works at all:

+			PERFORM pg_sleep(CASE WHEN count(*) = 0 THEN 0 ELSE 0.1 END)
+			FROM schema1.counted WHERE type = 'delta';
+			GET DIAGNOSTICS count = ROW_COUNT;

Given that it uses an aggregate, the ROW_COUNT must always be 1, no?

			regards, tom lane



Commits

  1. Increase test coverage for worker_spi by ∞%