Re: Virtual generated columns

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>

To: Dean Rasheed <dean.a.rasheed@gmail.com>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, jian he <jian.universality@gmail.com>

Date: 2024-11-12T16:06:37Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Expand virtual generated columns for ALTER COLUMN TYPE
- 5069fef1cfae 18.0 landed
Eliminate code duplication in replace_rte_variables callbacks
- 363a6e8c6fcf 18.0 landed
Expand virtual generated columns in the planner
- 1e4351af329f 18.0 landed
Virtual generated columns
- 83ea6c54025b 18.0 landed
Additional tests for stored generated columns
- 41084409f635 18.0 landed
Improve generated_stored test
- 44b61efb7928 18.0 landed
- 86749ea3b766 18.0 landed
Fix handling of CREATE DOMAIN with GENERATED constraint syntax
- 84a67725cd11 18.0 landed
Add pg_constraint rows for not-null constraints
- 14e87ffa5c54 18.0 cited
Put generated_stored test objects in a schema
- 894be11adfa6 18.0 landed
Rename regress test generated to generated_stored
- b9ed4969250d 18.0 landed
Small code simplification
- 7ff9afbbd1df 18.0 landed
Remove useless code
- e26d313bad92 18.0 landed
Remove useless initializations
- da2aeba8f533 18.0 landed
doc: Clarify that pg_attrdef also stores generation expressions
- da486d360103 18.0 landed
Clean out column-level pg_init_privs entries when dropping tables.
- 76618097a6c0 17.0 cited
Re-implement the ereport() macro using __VA_ARGS__.
- e3a87b4991cc 13.0 cited

Attachments

v9-0001-Virtual-generated-columns.patch (text/plain) patch v9-0001

On 07.11.24 10:35, Dean Rasheed wrote:
> On Tue, 5 Nov 2024 at 16:17, Peter Eisentraut <peter@eisentraut.org> wrote:
>>
>> New patch version.
> 
> What happened with the RLS support? It looks like you moved the code
> to expand virtual generated columns back to the first loop in
> fireRIRrules(), which doesn't work because RLS policies might contain
> references to virtual generated columns.
> 
> In the v7 patch, it was done in a separate loop, after the RLS policy
> loop, which I thought was fine, except that I didn't like having a
> whole new loop, opening and closing all the relations in the query.
> Was there some other problem with that approach?

I have no idea what happened there.  I must have used the wrong patch 
version at some point.  I have applied your patch to fix that back up. 
Also thanks for the RLS test cases.