Horton

Re: jsonb array-style subscripting

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2015-08-17T21:19:03Z
Lists: pgsql-hackers 
Dmitry Dolgov <9erthalion6@gmail.com> writes:
> * is that a good idea to extend the `ArrayRef` for jsonb?

No.  Make a new expression node type.

(Salesforce did something similar for an internal feature, and it was a
disaster both for code modularity and performance.  We had to change it to
a separate node type, which I just got finished doing.  Don't go down that
path.  While you're at it, I'd advise that fetch and assignment be two
different node types rather than copying ArrayRef's bad precedent of using
only one.)

			regards, tom lane

Commits

  1. Throw error when assigning jsonb scalar instead of a composite object

  2. Filling array gaps during jsonb subscripting

  3. Implementation of subscripting for jsonb