Re: Add Postgres module info
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Andrei Lepikhov <lepihov@gmail.com>,
PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2024-12-11T19:54:08Z
Lists: pgsql-hackers
Andres Freund <andres@anarazel.de> writes: > On 2024-12-11 13:21:03 -0500, Tom Lane wrote: >> There are a couple of ways that we could deal with the API >> seen by module authors: > To be future proof, I think it'd be good to declare the arguments as > designated initializers. E.g. like > PG_MODULE_MAGIC_EXT( > .version = 10000, > .threadsafe = 1 > ); Yeah, I'd come to pretty much the same conclusion after sending my email. That looks like it should work and be convenient to extend further. The other possibly-non-obvious bit is that we should probably invent a sub-structure holding the ABI-related fields, so as to minimize the amount of rewriting needed in dfmgr.c. regards, tom lane
Commits
-
Avoid mixing designated and non-designated field initializers.
- d66997dfe8fe 18.0 landed
-
Use PG_MODULE_MAGIC_EXT in our installable shared libraries.
- 55527368bd07 18.0 landed
-
Introduce PG_MODULE_MAGIC_EXT macro.
- 9324c8c58065 18.0 landed