Horton

Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]

Greg Smith <greg@2ndquadrant.com>

View thread View on postgr.es
From: Greg Smith <greg@2ndQuadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Greg Stark <stark@mit.edu>, Amit Kapila <amit.kapila@huawei.com>, Andres Freund <andres@2ndquadrant.com>, Boszormenyi Zoltan <zb@cybertec.at>, pgsql-hackers@postgresql.org
Date: 2013-03-21T19:05:44Z
Lists: pgsql-hackers 
On 3/21/13 2:38 PM, Robert Haas wrote:
> Also, while I think that MOST people will probably want a SIGHUP right
> after SET PERSISTENT, I am not sure that EVERYONE will want that.  If
> you want it and it doesn't happen automatically, you can always do it
> by hand.

This is a fair position, and since that's how the feature as written 
right now works that helps.  I think proceeding this way needs to hand 
some sort of hint back to the user though, telling them the change isn't 
active until SIGHUP.  The path I don't want to see if where someone uses 
SET PERSISTENT and can't figure out why nothing changed.  It should be 
as obvious as we can make it to someone that the explicit reload is 
necessary.

-- 
Greg Smith   2ndQuadrant US    greg@2ndQuadrant.com   Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.com