Re: Re: Proposal for Allow postgresql.conf values to be changed via SQL [review]
Boszormenyi Zoltan <zb@cybertec.at>
From: Boszormenyi Zoltan <zb@cybertec.at>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Amit kapila <amit.kapila@huawei.com>, 'Robert Haas' <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2013-01-18T20:48:25Z
Lists: pgsql-hackers
2013-01-18 21:32 keltezéssel, Tom Lane írta:
> Boszormenyi Zoltan <zb@cybertec.at> writes:
>> 2013-01-18 11:05 keltezéssel, Amit kapila írta:
>>> On using mktemp, linux compilation gives below warning
>>> warning: the use of `mktemp' is dangerous, better use `mkstemp'
>>>
>>> So I planned to use mkstemp.
>> Good.
> On my HPUX box, the man page disapproves of both, calling them obsolete
> (and this man page is old enough to vote, I believe...)
>
> Everywhere else that we need to do something like this, we just use our
> own PID to disambiguate, ie
> sprintf(tempfilename, "/path/to/file.%d", (int) getpid());
> There is no need to deviate from that pattern or introduce portability
> issues, since we can reasonably assume that no non-Postgres programs are
> creating files in this directory.
Thanks for the enlightenment, I will post a new version soon.
>
> regards, tom lane
>
>
--
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
http://www.postgresql.at/