Horton

Re: Slave enters in recovery and promotes when WAL stream with master is cut + delay master/slave

Heikki Linnakangas <hlinnakangas@vmware.com>

View thread View on postgr.es
From: Heikki Linnakangas <hlinnakangas@vmware.com>
To: Andres Freund <andres@2ndquadrant.com>
Cc: Michael Paquier <michael.paquier@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Date: 2013-01-17T17:29:52Z
Lists: pgsql-hackers 
On 17.01.2013 18:55, Andres Freund wrote:
> On 2013-01-17 18:50:35 +0200, Heikki Linnakangas wrote:
>> I was thinking of the attached. As long as we check for
>> CheckForStandbyTrigger() after the "record == NULL" check, we won't perform
>> extra stat() calls on successful reads, only when we're polling after
>> reaching the end of valid WAL. That seems acceptable.
>
> Looks good to me.

Ok, committed.

- Heikki

Commits

  1. Use the right timeline when beginning to stream from master.

  2. Split out XLog reading as an independent facility