Re: Database object names and libpq in UTF-8 locale on Windows

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Sebastien FLAESCH <sf@4js.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2013-01-11T22:16:00Z
Lists: pgsql-hackers
On 11/21/2012 12:07 PM, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> On 11/21/2012 11:11 AM, Tom Lane wrote:
>>> I'm not sure that's the only place we're doing this ...
>> Oh, Hmm, darn. Where else do you think we might?
> Dunno, but grepping for isupper and/or tolower should find any such
> places.
>
> 			


I've eliminated some false positives from the grep results. and here's a 
list of list of the remaining files doing things that could be suspect. 
Haven't had time to dig more.

    src/backend/regex/regc_locale.c
    src/backend/regex/regcomp.c
    src/backend/regex/regc_pg_locale.c
    src/backend/tsearch/ts_locale.c
    src/backend/utils/adt/datetime.c
    src/backend/utils/adt/formatting.c
    src/backend/utils/adt/inet_net_pton.c
    src/backend/utils/adt/like.c
    src/backend/utils/misc/tzparser.c


I'd be tempted to say we should fix up the identifier issue regardless 
of the rest, though.

cheers

andrew