Re: [PATCH] PL/Python: Add spidata to all spiexceptions
Jan Urbański <wulczer@wulczer.org>
From: Jan Urbański <wulczer@wulczer.org>
To: "Karl O. Pinc" <kop@meme.com>
Cc: Oskari Saarenmaa <os@ohmu.fi>, pgsql-hackers@postgresql.org
Date: 2013-01-09T19:08:39Z
Lists: pgsql-hackers
On 12/12/12 20:21, Karl O. Pinc wrote: >>> There were 2 outstanding issue raised: >>> >>> Is this useful enough/proceeding in the right direction to commit >>> now? >> >>> Should some of the logic be moved out of a subroutine and into the >>> calling code? >> > I can see arguments to be made for both sides. I'm asking that you > think it through to the extent you deem necessary and make > changes or not. At that point it should be ready to send > to a committer. (I'll re-test first, if you make any changes.) Oh my, I have dropped the ball on this one in the worst manner possible. Sorry! I actually still prefer to keep the signatures of PLy_get_spi_sqlerrcode and PLy_get_spi_error_data similar, so I'd opt for keeping the patch as-is :) Thanks, Jan