Re: [PATCH 2/5] Make relpathbackend return a statically result instead of palloc()'ing it

Heikki Linnakangas <hlinnakangas@vmware.com>

From: Heikki Linnakangas <hlinnakangas@vmware.com>
To: Andres Freund <andres@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Date: 2013-01-08T21:02:15Z
Lists: pgsql-hackers
On 08.01.2013 23:00, Andres Freund wrote:
>> Note that the xlogreader facility doesn't need any more emulation. I'm quite
>> satisfied with that part of the patch now. However, the rmgr desc routines
>> do, and I'm not very happy with those. Not sure what to do about it. As you
>> said, we could add enough infrastructure to make them compile in frontend
>> context, or we could try to make them rely less on backend functions.
>
> Which emulation needs are you missing in the desc routines besides
> relpathbackend() and timestamptz_to_str()? pfree() is "just" needed
> because its used to free the result of relpathbackend(). No own pallocs,
> no ereport ...

Nothing besides those, those are the stuff I was referring to.

- Heikki


Commits

  1. Prevent creation of postmaster's TCP socket during pg_upgrade testing.