Horton

Thread

  1. Minor fix in 'clean' action of 'src/backend/Makefile'

    Fabrízio de Royes Mello <fabriziomello@gmail.com> — 2013-01-02T16:05:17Z

    Hi all,

When we execute 'make clean' the file 'src/backend/replication/repl_gram.h'
 is not removed.

The attached patch fix it.

Regards,

-- 
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Blog sobre TI: http://fabriziomello.blogspot.com
>> Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello

  2. Re: Minor fix in 'clean' action of 'src/backend/Makefile'

    Heikki Linnakangas <hlinnakangas@vmware.com> — 2013-01-02T16:20:21Z

    On 02.01.2013 18:05, Fabrízio de Royes Mello wrote:
> Hi all,
>
> When we execute 'make clean' the file 'src/backend/replication/repl_gram.h'
>   is not removed.

That's on purpose. repl_gram.h is generated by bison, along with 
repl_gram.c. Neither is removed by "make clean", because they're needed 
in a distribution tarball. "make maintainer-clean" does remove them.

Hmm, looking closer though, repl_gram.h is not actually needed for 
anything, though. We could just remove the -d flag from the bison 
invocation and not build it to begin with. I'll go and do that..

- Heikki

  3. Re: Minor fix in 'clean' action of 'src/backend/Makefile'

    Heikki Linnakangas <hlinnakangas@vmware.com> — 2013-01-02T16:23:08Z

    On 02.01.2013 18:20, Heikki Linnakangas wrote:
> Hmm, looking closer though, repl_gram.h is not actually needed for
> anything, though. We could just remove the -d flag from the bison
> invocation and not build it to begin with. I'll go and do that..

And looking even closer, we don't use the -d flag in git master anymore, 
so repl_gram.h is not being built, and there's nothing to do here. I 
suppose we could change back-branches to also not build it, but I don't 
think I'm going to bother.

- Heikki

  4. Re: Minor fix in 'clean' action of 'src/backend/Makefile'

    Fabrízio de Royes Mello <fabriziomello@gmail.com> — 2013-01-02T17:26:42Z

    On Wed, Jan 2, 2013 at 2:23 PM, Heikki Linnakangas
<hlinnakangas@vmware.com>wrote:

> On 02.01.2013 18:20, Heikki Linnakangas wrote:
>
>> Hmm, looking closer though, repl_gram.h is not actually needed for
>> anything, though. We could just remove the -d flag from the bison
>> invocation and not build it to begin with. I'll go and do that..
>>
>
> And looking even closer, we don't use the -d flag in git master anymore,
> so repl_gram.h is not being built, and there's nothing to do here. I
> suppose we could change back-branches to also not build it, but I don't
> think I'm going to bother.
>
>
You all right... thanks....

-- 
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Blog sobre TI: http://fabriziomello.blogspot.com
>> Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello