Re: proposal: separate databases for contrib module testing

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2012-12-02T17:36:32Z
Lists: pgsql-hackers

Attachments

On 12/02/2012 11:29 AM, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> On 12/02/2012 10:05 AM, Tom Lane wrote:
>>> Personally I always thought that was a feature not a bug.  If we give
>>> each one its own DB, there will be a couple of dozen databases
>>> cluttering the installation at the end of "make installcheck", and no
>>> convenient way to get rid of them.
>> How about if we have a make target to clean these databases out,
>> "installcheck-clean", maybe? Alternatively, or in addition, how about if
>> we have a separate make target to do things the way I'm suggesting,
>> assuming I can make that work?
> Either of those would satisfy my concern.  The latter might be a bit
> easier, not sure.
>
> 			



Yeah. This lets me get what I want, via "make USE_MODULE_DB=1 
installcheck", don't even need a new target. There's probably a case for 
doing the same sort of thing for the pl_* makefiles on the basis of 
consistency, not sure if it's worth it though.

cheers

andrew