Horton
Menu

Re: [BUG] False indication in pg_stat_replication.sync_state

Heikki Linnakangas <hlinnakangas@vmware.com>

View thread
From: Heikki Linnakangas <hlinnakangas@vmware.com>
To: Fujii Masao <masao.fujii@gmail.com>, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2012-11-23T17:16:43Z
Lists: pgsql-hackers 
On 09.11.2012 15:28, Fujii Masao wrote:
> On Fri, Nov 9, 2012 at 4:06 AM, Alvaro Herrera<alvherre@2ndquadrant.com>  wrote:
>> Fujii Masao escribió:
>>> On Fri, Oct 19, 2012 at 10:29 PM, Fujii Masao<masao.fujii@gmail.com>  wrote:
>>
>>>>>> However, I've forgotten to treat other three portions in
>>>>>> walsender.c and syncrep.c also does XLogRecPtrIsInvalid(<XLogPtr
>>>>>> which comes from WAL receiver>).  This new patch includes the
>>>>>> changes for them.
>>>>
>>>> Good catch.
>>>
>>> Does any commiter pick up this?
>>
>> If not, please add to next commitfest so that we don't forget.
>
> Yep, I added this to next CF. This is just a bug fix, so please feel free to
> pick up this even before CF.

Committed, thanks.

- Heikki

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Replace XLogRecPtr struct with a 64-bit integer.