Horton

Re: Statistical aggregate functions are not working with PARTIAL aggregation

Andres Freund <andres@anarazel.de>

View thread View on postgr.es
From: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>,Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>,Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>,PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-05-20T15:23:51Z
Lists: pgsql-hackers 
Hi,

On May 20, 2019 6:23:46 AM PDT, Robert Haas <robertmhaas@gmail.com> wrote:
>On Sun, May 19, 2019 at 2:36 PM Andres Freund <andres@anarazel.de>
>wrote:
>> Not sure I understand the distinction you're trying to make with the
>> variable renaming. The combine function is also a transition
>function,
>> no?
>
>Not in my mental model.  It's true that a combine function is used in
>a similar manner to a transition function, but they are not the same
>thing.

Well, the context here is precisely that. We're still calling functions that have trans* in the name, we pass them transfn style named parameters. If you read my suggestion, it essentially is running go *further* than David's renaming?

Andres
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Commits

  1. Minimally fix partial aggregation for aggregates that don't have one argument.

  2. Change function call information to be variable length.