Re: Undesirable entries in typedefs list
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2018-03-27T22:02:47Z
Lists: pgsql-hackers
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> pgindent already has a list of blacklisted typedefs (see lines 121 to 123)
Oh, so it does.
> Here's a patch to pgindent which I think will do what you want fairly
> simply, assuming you have identified all the offending tokens.
Hm, this does not work for me (with perl 5.10.1), I get syntax errors like
Not enough arguments for map at src/tools/pgindent/pgindent line 64, near "abs allocfunc iterator other pointer printfunc reference string type )"
(Might be a runaway multi-line () string starting on line 63)
syntax error at src/tools/pgindent/pgindent line 64, near "abs allocfunc iterator other pointer printfunc reference string type )"
Execution of src/tools/pgindent/pgindent aborted due to compilation errors.
After reading the perlfunc man page I changed
-my %blacklist = map { "$_\n" => 1 }
+my %blacklist = map { +"$_\n" => 1 }
and then it seems to work, but man this is an ugly language :-(
regards, tom lane
Commits
-
Update pgindent's typedefs blacklist, and make it easier to adjust.
- ef1978d6ed1e 11.0 landed