Horton

Re: Add new COPY option REJECT_LIMIT

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: torikoshia <torikoshia@oss.nttdata.com>, jian.universality@gmail.com
Cc: zhjwpku@gmail.com, pgsql-hackers@lists.postgresql.org
Date: 2024-10-08T09:39:54Z
Lists: pgsql-hackers 

On 2024/10/07 21:51, torikoshia wrote:
>> While reviewing, I also noticed that the check for
>> "opts_out->binary && opts_out->on_error != COPY_ON_ERROR_STOP"
>> is similarly placed before setting the defaults, which might not
>> be correct. This check should probably be moved as well.
>> Additionally, the comment mentioning "must do these two" should be
>> updated to "must do these three." These changes should be handled
>> in a separate patch.
> 
> Agreed and attached 0002 patch.

Thanks for updating the 0001 patch and creating the 0002 patch! I've pushed both.


> Also considering when REJECT_LIMIT is specified to 1, attached patch uses errmsg_plural() instead of errmsg.

I don't think errmsg_plural() is needed here since, when 1 is specified,
"rows" should follow "more than REJECT_LIMIT (1)". No?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. Move check for binary mode and on_error option to the appropriate location.

  2. Add REJECT_LIMIT option to the COPY command.