Re: Add pg_stat_recovery system view

> On Mar 9, 2026, at 14:06, Michael Paquier <michael@paquier.xyz> wrote:
> 
> On Mon, Mar 09, 2026 at 01:20:45PM +0800, Chao Li wrote:
>>> [1] https://www.postgresql.org/docs/devel/error-message-reporting.html
>> 
>> Would it make sense to mention this distinction in the header
>> comments for ereport and elog in the code? For these logging APIs, I
>> think developers are often more likely to read the code comments
>> than the documentation.
> 
> As of the link already mentioned:
> "Therefore, elog should be used only for internal errors .."
> --
> Michael

Yes, the doc has clearly explained everything. I meant to ask if we want to add a bit explanation to the header comment of elog and ereport. Currently elog’s comment only says:
```
/*----------
* Old-style error reporting API: to be used in this way:
*        elog(ERROR, "portal \"%s\" not found", stmt->portalname);
*----------
```
That sounds elog is just old, but somewhat equivalent to ereport.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/