Horton

Re: [PATCH] Perform check for oversized WAL record before calculating record CRC

Andrey Borodin <x4mmm@yandex-team.ru>

View thread
From: Andrey Borodin <x4mmm@yandex-team.ru>
To: Sergey Fukanchik <s.fukanchik@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org
Date: 2025-09-06T17:30:52Z
Lists: pgsql-hackers 

> On 6 Sep 2025, at 16:00, Sergey Fukanchik <s.fukanchik@postgrespro.ru> wrote:
> 
> <0001-Perform-check-for-oversized-WAL-record-before-calcul.patch>

Hi Sergey!

It seems to me reasonable to move size check above CRC computation. However, it seems suspicious to me to run a test that allocates 1Gb in `make check`. Maybe, there are places that are not exercised too often. Perhaps recovery tests or something like that.


Best regards, Andrey Borodin.