Re: plpgsql_check_function - rebase for 9.3
Andrew Dunstan <andrew@dunslane.net>
From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Selena Deckelmann <selena@chesnok.com>, Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2012-10-07T15:39:15Z
Lists: pgsql-hackers
On 10/07/2012 11:25 AM, Tom Lane wrote: > Selena Deckelmann <selena@chesnok.com> writes: >> This also represents my inaugural use of pg_bsd_indent. I ran it on >> pl_check.c - which made things mostly better. Happy to try and fix it >> up more if someone can explain to me what (if anything) I did >> incorrectly when using it. > It looks like you didn't give it a typedef list? Fetch the file from > http://buildfarm.postgresql.org/cgi-bin/typedefs.pl > and pass it with --typedefs=filename. If you're dealing with something > that adds new typedef names, you can add them to the list file manually. > > You's not supposed to be calling pg_bsd_indent directly at all. You's supposed to be calling pgindent - it will call pg_bsd_indent as needed and adjust the results. See src/tools/pgindent/README. cheers andrew