Horton
Menu

Re: [PATCH] Make pg_basebackup configure and start standby [Review]

Boszormenyi Zoltan <zb@cybertec.at>

View thread
From: Boszormenyi Zoltan <zb@cybertec.at>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter_e@gmx.net>, Amit Kapila <amit.kapila@huawei.com>, 'Hans-Jürgen Schönig' <hs@cybertec.at>, 'Pg Hackers' <pgsql-hackers@postgresql.org>, Magnus Hagander <magnus@hagander.net>, Fujii Masao <masao.fujii@gmail.com>
Date: 2012-10-04T16:19:36Z
Lists: pgsql-hackers

Attachments

2012-10-04 16:43 keltezéssel, Tom Lane írta:
> Boszormenyi Zoltan <zb@cybertec.at> writes:
>>> Did you think about something like the attached code?
>> Or rather this one, which fixes a bug so fillPGconn() and PQconninfo() are
>> symmetric and work for "requiressl".
> That's incredibly ugly.  I'm not sure where we should keep the "R"
> information, but shoehorning it into the existing PQconninfoOption
> struct like that seems totally unacceptable.  Either we're willing to
> break backwards compatibility on the Disp-Char strings, or we need
> to put that info somewhere else.

I hope only handling the new flag part is ugly. It can be hidden
in the PQconninfoMapping[] array and PQconninfo(conn, true)
pre-filters the list as in the attached version.

Best regards,
Zoltán Böszörményi

-- 
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt, Austria
Web: http://www.postgresql-support.de
      http://www.postgresql.at/

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Make the streaming replication protocol messages architecture-independent.