Re: 9.2 pg_upgrade regression tests on WIndows

On 09/05/2012 10:41 PM, Bruce Momjian wrote:
>
> I would like to see a more verbose comment, so we don't forget why we
> did this.  I think my inability to quickly discover the cause of the
> previous log write problem is that I didn't document which file
> descriptors are kept open on Windows.  I suggest for a comment:
>
> 	/*
> 	 * "pg_ctl -w stop" might have reported that the server has
> 	 * stopped because the postmaster.pid file has been removed,
> 	 * but "pg_ctl -w start" might still be in the process of
> 	 * closing and might still be holding its stdout and -l log
> 	 * file descriptors open.  Therefore, try to open the log
> 	 * file a few times.
> 	 */
>
> Anyway, we can easily adjust the comment post-9.2.0.


Shall I apply the patch now? If so I'll include your comment.

cheers

andrew