Re: Cascading replication and recovery_target_timeline='latest'

Heikki Linnakangas <hlinnaka@iki.fi>

From: Heikki Linnakangas <hlinnaka@iki.fi>

To: Peter Eisentraut <peter_e@gmx.net>

Cc: pgsql-hackers@postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>, Josh Berkus <josh@agliodbs.com>

Date: 2012-09-05T05:09:24Z

Lists: pgsql-hackers

On 04.09.2012 21:56, Peter Eisentraut wrote:
> On Tue, 2012-09-04 at 19:34 -0700, Heikki Linnakangas wrote:
>>> The attached patch fixes it for me. It fixes the original problem, by
>>> adding the missing locking and terminating walsenders on a target
>>> timeline change, and also changes the behavior wrt. WAL segments
>>> restored from the archive, as I just suggested in another email
>>> (http://archives.postgresql.org/pgsql-hackers/2012-09/msg00206.php).
>>
>> Committed that.
>
> New compiler warnings:
>
> xlog.c: In function ‘XLogFileRead’:
> xlog.c:2785:14: error: unused variable ‘endptr’ [-Werror=unused-variable]
> xlog.c:2784:25: error: unused variable ‘xlogctl’ [-Werror=unused-variable]

Fixed, thanks.

- Heikki