Re: pg_upgrade del/rmdir path fix

Andrew Dunstan <andrew@dunslane.net>

View thread

From: Andrew Dunstan <andrew@dunslane.net>

To: Alvaro Herrera <alvherre@2ndquadrant.com>

Cc: Bruce Momjian <bruce@momjian.us>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2012-09-05T00:54:22Z

Lists: pgsql-hackers

Attachments

pg_upgrade_relfilenode_log.patch (text/x-patch) patch

On 09/04/2012 02:25 PM, Andrew Dunstan wrote:
>
> On 09/04/2012 10:42 AM, Alvaro Herrera wrote:
>
>>
>> Somehow the verbose reporting of user relation files being copied does
>> not seem exceedingly useful; and I don't remember seeing that on Linux.
>>
>
>
> Yeah, and it does something odd anyway when it's not writing to a 
> terminal. Can we get rid of it, or make it only work in verbose mode?
>
>

The attached is an attempt to fix this. I think it handles most of 
what's wrong with this. (The patch is bigger because the code currently 
uses a variable called "fileno" - not a good idea.)

cheers

andrew