Re: _USE_32BIT_TIME_T Patch

Andrew Dunstan <andrew@dunslane.net>

From: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dave Page <dpage@pgadmin.org>, Owais Khan <owais.khan@enterprisedb.com>, pgsql-hackers@postgresql.org, Hamid Quddus <hamid.quddus@enterprisedb.com>
Date: 2012-09-01T00:35:48Z
Lists: pgsql-hackers
On 08/31/2012 06:39 PM, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> I'm not  sure what we need to do to progress on this, especially re the
>> back branches.
> The calendar might help us here.  9.2 is due to wrap next week, but it
> will likely be a couple of months before we contemplate new back-branch
> releases.  So we could push a fix that we don't have 100% confidence in,
> knowing that there is time to recover before it will ship in any of the
> proven branches.  Releasing it in 9.2.0 will afford an opportunity for
> more testing than we can do by ourselves.
>
> That's not to take anything away from the fact that we ought to test as
> many cases as we can now.  But we do have some margin for error.
>
> 			


OK, so I have tested it on my 32bit setup and it's working, so I'm going 
to commit this for HEAD/9.2 now, so we can get that wider testing.

cheers

andrew


Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Replace time_t with pg_time_t (same values, but always int64) in on-disk

  2. Use _USE_32BIT_TIME_T when building with MSVC. Also, enforce that it's