Re: BM_IO_ERROR flag is lost in TerminateBufferIO due to order of operations in UnlockBufHdrExt

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Yura Sokolov <y.sokolov@postgrespro.ru>, pgsql-hackers@lists.postgresql.org
Date: 2026-06-03T03:21:49Z
Lists: pgsql-hackers
Hi,

On 2026-06-02 12:15:40 -0400, Melanie Plageman wrote:
> On Mon, Apr 6, 2026 at 4:21 AM Michael Paquier <michael@paquier.xyz> wrote:
> >
> > On Mon, Mar 30, 2026 at 11:25:55AM +0300, Yura Sokolov wrote:
> > > Have you any recommendations for patch?
> > >
> > > Should I create CF item for patch?
> >
> > The business with unset_flag_bits is new as of HEAD, so this could
> > qualify as an open item, to be tracked here:
> > https://wiki.postgresql.org/wiki/PostgreSQL_19_Open_Items
> 
> There hasn't been recent activity on this thread and it is one of the
> oldest open items. Even if we don't have time to review the test right
> now, it is probably worth pushing the fix. Though we have just missed
> beta1...

Ugh. I had lost track of this.  I'll get back to it as soon as I have squared
the CI stuff away.

Greetings,

Andres Freund