Horton

Re: split tablecmds.c

Andres Freund <andres@anarazel.de>

View thread
From: Andres Freund <andres@anarazel.de>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2025-12-01T19:50:44Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Split copy.c into four files.

  2. The contents of command.c, creatinh.c, define.c, remove.c and rename.c

Hi,

On 2025-12-01 11:25:13 -0600, Nathan Bossart wrote:
> This file has over 22,000 lines and is too large to be included in GitHub's
> code search results [0].  It appears to have been given its current form in
> 2002 by commit 71dc300.  Previously, it was named command.c, which dates
> back to the 80s.  Is it time to split it into a few different files,
> similar to what was done to copy.c in 2020 by commit c532d15?
> 
> After briefly skimming through it, some areas that seem like they could
> potentially be moved out are partitions, constraints, permission checks,
> inheritance, foreign keys, column expressions, table rewriting, attribute
> merging, TRUNCATE, and CREATE TABLE.  This is far from a concrete proposal,
> but I first wanted to gauge interest in $SUBJECT.

Seems reasonable, however I think that splitting all or most of the pieces you
listed into their own files would end up being pointlessly granular....

Greetings,

Andres Freund