Re: pure parsers and reentrant scanners

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>

To: Andreas Karlsson <andreas@proxel.se>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2024-12-18T09:42:37Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Return yyparse() result not via global variable
- 473a575e0597 18.0 landed
Remove flex version checks
- 0869ea43e9c2 18.0 landed
Drop warning-free support for Flex 2.5.35
- 6fdd5d956343 18.0 landed
plpgsql: pure parser and reentrant scanner
- 7b27f5fd36cb 18.0 landed
flex code modernization: Replace YY_EXTRA_TYPE define with flex option
- b1ef48980ddd 18.0 landed
guc: reentrant scanner
- d663f150b5ed 18.0 landed
jsonpath scanner: reentrant scanner
- 2a7425d7eef9 18.0 landed
syncrep parser: pure parser and reentrant scanner
- db6856c9913f 18.0 landed
replication parser: pure parser and reentrant scanner
- e4a8fb8fefb9 18.0 landed
bootstrap: pure parser and reentrant scanner
- 3e4bacb17100 18.0 landed
Small whitespace improvement
- 399d0f1e11b5 18.0 landed
Prevent redeclaration of typedef yyscan_t
- 382092a0cd2c 18.0 landed
seg: pure parser and reentrant scanner
- 1f0de66ea2a5 18.0 landed
cube: pure parser and reentrant scanner
- 802fe923e3cd 18.0 landed

Attachments

typedef-yyscan_t-fix.patch.nocfbot (text/plain)

I started committing the cube and seg pieces.  There were a couple of 
complaints from the buildfarm, like

ccache clang -std=gnu99 -Wall -Wmissing-prototypes -Wpointer-arith 
-Wdeclaration-after-statement -Werror=vla 
-Werror=unguarded-availability-new -Wendif-labels 
-Wmissing-format-attribute -Wcast-function-type -Wformat-security 
-Wmissing-variable-declarations -fno-strict-aliasing -fwrapv 
-Wno-unused-command-line-argument -Wno-compound-token-split-by-macro -g 
-O2 -fno-common -fsanitize=alignment -fsanitize-trap=alignment 
-Wno-deprecated-declarations -Werror  -fvisibility=hidden -I. -I. 
-I../../src/include  -isysroot 
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk 
-DWRITE_READ_PARSE_PLAN_TREES -DSTRESS_SORT_INT_MIN 
-DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS 
-I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include 
-I/usr/local/include  -I/usr/local/ssl/include  -c -o segscan.o segscan.c
segscan.c:348:15: error: redefinition of typedef 'yyscan_t' is a C11 
feature [-Werror,-Wtypedef-redefinition]
typedef void* yyscan_t;
               ^
./segdata.h:19:15: note: previous definition is here
typedef void *yyscan_t;
               ^

I can fix that with the attached patch.

The symbol YY_TYPEDEF_YY_SCANNER_T isn't documented, but we already use 
it elsewhere in the code.

Note that in replication/syncrep.h and replication/walsender_private.h 
we have to have an #ifndef wrapper because there are files that end up 
including both headers.  Maybe we should put that #ifndef wrapper 
everywhere for consistency?

Any thoughts?

(Also, we should probably figure out a way to get these warnings before 
things hit the buildfarm.)