Re: Proposal - Allow extensions to set a Plan Identifier

Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>

From: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>

To: Sami Imseih <samimseih@gmail.com>, Michael Paquier <michael@paquier.xyz>, Andrei Lepikhov <lepihov@gmail.com>

Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Lukas Fittl <lukas@fittl.com>

Date: 2025-03-18T11:46:11Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Allow plugins to set a 64-bit plan identifier in PlannedStmt
- 2a0cd38da5cc 18.0 landed

Hi,

Thank you for the patches. They're very important for many extensions.

I've debugged them using simple extensions pg_stat_statements and 
auto_explain, specifically checking cases involving PlannedStmt 
and pg_stat_get_activity - , and haven't encountered any issues so far.

However, I have a question: what value should planid have when we 
execute the standard planner without using a planner_hook? For example, 
if pg_stat_statementsis disabled, would planid default to zero? If zero 
is the expected default, should we explicitly write this behavior?

result->planid = 0;

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.