Horton

Re: Use pg_icu_unicode_version(void) instead of pg_icu_unicode_version()

Jeff Davis <pgsql@j-davis.com>

View thread View on postgr.es
From: Jeff Davis <pgsql@j-davis.com>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2026-03-03T04:16:32Z
Lists: pgsql-hackers 
On Fri, 2026-02-27 at 04:46 +0000, Bertrand Drouvot wrote:
> Hi hackers,
> 
> Standard practice in PostgreSQL is to use "foo(void)" instead of
> "foo()", as the
> latter looks like an "old-style" function declaration. 9b05e2ec08a
> did fix
> all the ones reported by -Wstrict-prototypes.
> 
> af2d4ca191a4 introduced a new one, this patch fixes it.

Committed, thank you.

Regards,
	Jeff Davis

Commits

  1. Enable -Wstrict-prototypes and -Wold-style-definition by default

  2. Prevent -Wstrict-prototypes and -Wold-style-definition warnings

  3. style: define parameterless functions as foo(void).