Horton

Re: Checks in RegisterBackgroundWorker.()

Heikki Linnakangas <hlinnaka@iki.fi>

View thread View on postgr.es
From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-10-09T08:52:58Z
Lists: pgsql-hackers 
On 06/10/2023 13:13, Thomas Munro wrote:
> On Thu, Sep 28, 2023 at 9:46 AM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> Subject: [PATCH v2 3/3] Fix misleading comment on StartBackgroundWorker().
> 
> LGTM.  Hmm, maybe I would have called that function
> "BackgroundWorkerMain()" like several other similar things, but that's
> not important.

That's a good idea. I renamed it to BackgroundWorkerMain().

Pushed with that change, thanks for the review!

-- 
Heikki Linnakangas
Neon (https://neon.tech)

Commits

  1. Rename StartBackgroundWorker() to BackgroundWorkerMain().

  2. Allocate Backend structs in PostmasterContext.

  3. Clarify the checks in RegisterBackgroundWorker.