Horton
Menu

Re: Fix logging for invalid recovery timeline

Benoit Lobréau <benoit.lobreau@dalibo.com>

View thread
From: Benoit Lobréau <benoit.lobreau@dalibo.com>
To: David Steele <david@pgbackrest.org>, "Andrey M. Borodin" <x4mmm@yandex-team.ru>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2025-02-19T09:51:49Z
Lists: pgsql-hackers 
Hi,

I think the changes make sense. Would it be helpful to add the origin of 
the checkpoint record we are referring to ? (i.e. control file or backup 
label).

For example:

* Latest checkpoint in the control file is at %X/%X on timeline %u,
* Checkpoint location in the backup_label file is at %X/%X on timeline %u,

The current message refers to "Latest checkpoint" which automatically 
makes me think about the control file (specifically, the pg_controldata 
output).

Now that I have read the code, I understand which one we are referring 
to, but for someone who hasn't (or me in a few month) it might be useful ?

-- 
Benoit Lobréau
Consultant
http://dalibo.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Improve FATAL message for invalid TLI history at recovery

  2. Fix FATAL message for invalid recovery timeline at beginning of recovery