Thread

Re: Add SPLIT PARTITION/MERGE PARTITIONS commands

Dmitry Koval <d.koval@postgrespro.ru> — 2024-12-09T21:01:43Z

Thank you for email!


 >The patches currently doesn't apply cleanly.  Please, rebase.

I did rebase and made few fixes that were needed after the recent 
vanilla changes (added ATT_PARTITIONED_TABLE flag for 
ATSimplePermissions function + added creation of not-null constraints in 
the createTableConstraints function).
The patches are attached to the email.


 >I think the code requires some polishing: you need to revise
 > the comments given its not part of LIKE clause handling anymore.

I removed couple of lines from comment and a few lines from 
documentation, I hope that's enough ...


 >I see fixes for the issues mentioned in [1] and [2] are still not
 >implemented.  Do you plan to do this in this release cycle?

I would like to make some changes, but I think it would be appropriate 
to discuss these points first.
As far as I understand, there is currently no clear opinion on how to 
implement [1] and [2].


I would appreciate your opinions on what improvements are really needed 
and in what order they should be implemented.

-- 
With best regards,
Dmitry Koval

Postgres Professional: http://postgrespro.com