Re: generate_series for timestamptz and time zone problem

Przemysław Sztoch <przemyslaw@sztoch.pl>

From: Przemysław Sztoch <przemyslaw@sztoch.pl>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2022-06-14T19:46:26Z
Lists: pgsql-hackers

Attachments

Tom Lane wrote on 14.06.2022 15:43:
> =?UTF-8?Q?Przemys=c5=82aw_Sztoch?= <przemyslaw@sztoch.pl> writes:
>> Please let me know what is the convention (procedure) of adding new
>> functions to pg_proc. Specifically how oid is allocated.
> See
> https://www.postgresql.org/docs/devel/system-catalog-initial-data.html#SYSTEM-CATALOG-OID-ASSIGNMENT
> (you should probably read that whole chapter for context).
Thx.

There is another patch.
It works, but one thing is wrongly done because I lack knowledge.

Where I'm using DirectFunctionCall3 I need to pass the timezone name, 
but I'm using cstring_to_text and I'm pretty sure there's a memory leak 
here. But I need help to fix this.
I don't know how best to store the timezone in the generate_series 
context. Please, help.
-- 
Przemysław Sztoch | Mobile +48 509 99 00 66

Commits

  1. Add functions to do timestamptz arithmetic in a non-default timezone.

  2. Refactor datetime functions' timezone lookup code to reduce duplication.

  3. Fix volatility marking of timestamptz_trunc_zone.