Horton
Menu

Re: psql: fix variable existence tab completion

Anton A. Melnikov <a.melnikov@postgrespro.ru>

View thread
From: "Anton A. Melnikov" <a.melnikov@postgrespro.ru>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alexander Korotkov <aekorotkov@gmail.com>, Erik Wienhold <ewie@ewie.name>, Steve Chavez <steve@supabase.io>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2024-07-20T23:24:25Z
Lists: pgsql-hackers

Attachments

On 19.07.2024 01:10, Tom Lane wrote:
> Actually, I think we ought to just reject this change.  Debian 10
> will be two years past EOL before PG 17 ships.  So I don't see a
> reason to support it in the tests anymore.  One of the points of
> such testing is to expose broken platforms, not mask them.
> 
> Obviously, if anyone can point to a still-in-support platform
> with the same bug, that calculus might change.

The bug when broken version of libedit want to backslash some symbols
(e.g. double quotas, curly braces, the question mark)
i only encountered on Debian 10 (buster).

If anyone has encountered a similar error on some other system,
please share such information.


> With respect to the other hacks Alexander mentions, maybe we
> could clean some of those out too?  I don't recall what platform
> we had in mind there, but we've moved our goalposts on what
> we support pretty far in the last couple years.

Agreed that no reason to save workarounds for non-supported systems.
Here is the patch that removes fixes for Buster bug mentioned above.


With the best regards,

-- 
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove test-case workarounds for ancient libedit versions.

  2. psql: fix variable existence tab completion